Repository navigation
README: link Examples/README.md from the More examples section - #90
Merged
Merged
Conversation
The README's More examples section listed the 21 example projects but not Examples/README.md, which explains how to set CONVERTAPI_TOKEN and run an example. PRs 83 and 85 agreed that whichever merged second would add this link. Both merged without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the README update adding token setup guidance and a link to the example-running instructions.
No open issues 🎉
What changed in this PR
Connects the main README’s example list to the setup and execution guide, completing the documentation follow-up from #83 and #85.
Changes:
- Tells readers to set
CONVERTAPI_TOKENbefore running an example. - Adds an absolute link to
Examples/README.md, preserving the existing heading anchor and example links.
| File | Description |
|---|---|
| README.md | Adds token setup guidance and a link to the example-running instructions under “More examples.” |
Review effort: Balanced
kostas-jonauskas
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One sentence in the README's "More examples" section. It now says how to run an example and links https://github.com/ConvertAPI/convertapi-library-dotnet/blob/main/Examples/README.md, which explains how to set
CONVERTAPI_TOKEN, run an example withdotnet run --project, and where the sample files are.The
### More examplesheading is unchanged, so links to#more-examplesstill work.Why
The section listed all 21 example projects but never said how to run them. #83 and #85 agreed that whichever merged second would add this link, because
Examples/README.mdexisted only on #85's branch until then. Both merged without it.Checks
publish.ymlonly rewritesutm_source=githublinks, and this link has no tags.CHANGELOG.mdentry, becauseRELEASING.mdasks for one only when behaviour changes.🤖 Generated with Claude Code